-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand CODEOWNERS to each learn section owner/advocate #7292
Comments
@AugustinMauroy identified these already test-runner should be under the test-runner team |
Note that we can only take action on this when we have clearly defined the learning path/graph and each subsection is associated with one or two teams max. |
I've added it to the agenda to get their opinion on the matter. |
No problem with adding @nodejs/typescript as codeowner of the typescript related content for review |
ping @nodejs/test_runner to move forward on this issue |
Hey @AugustinMauroy, no problem for me regarding @nodejs/test_runner. |
I'm happy to do, although I'm not as active an implementer as Chemi, Colin, and Moshe. |
I'm not quite sure what is being asked of me in this issue? I think using the test_runner team as CODEOWNERS is fine if that's the question. It's worth noting though that none of the subsystem specific teams actually represent expertise in that subsystem. It just means that those people have subscribed to notifications. |
And have to approve PRs |
In Node Core, being part of the team does not grant any particular ownership. |
Node core actually looked into leveraging CODEOWNERS years ago. That was exactly the problem though. Any collaborator can join any team and approve things... which defeats the whole purpose of CODEOWNERS. |
That another question. IDK if there are a way to disable self joining team. EDIT: we cannot "join as it" we can request to join. IDK who approve that but there are a step before joining any team But for now we need someone that take care of nodejs learn content and it's why we use CODEOWNERS |
CODEOWNERS improvements associated to teams related to the APIs highlighted in the learn content
for each identified api module / team:
write
access if missing (CODEOWNERS must have write access)The text was updated successfully, but these errors were encountered: