Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CODEOWNERS to each learn section owner/advocate #7292

Open
3 tasks
bmuenzenmeyer opened this issue Nov 29, 2024 · 12 comments
Open
3 tasks

Expand CODEOWNERS to each learn section owner/advocate #7292

bmuenzenmeyer opened this issue Nov 29, 2024 · 12 comments
Labels
learn Issues/pr concerning the learn section

Comments

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Nov 29, 2024

Broken out of #7197
Might be related to #7198

CODEOWNERS improvements associated to teams related to the APIs highlighted in the learn content

for each identified api module / team:

  • add a team, or expand access to write access if missing (CODEOWNERS must have write access)
  • add the team and content paths to CODEOWNERS
@bmuenzenmeyer
Copy link
Collaborator Author

@AugustinMauroy identified these already

test-runner should be under the test-runner team
typescript should be under typescript team

@bmuenzenmeyer bmuenzenmeyer added the learn Issues/pr concerning the learn section label Nov 29, 2024
@AugustinMauroy
Copy link
Member

Note that we can only take action on this when we have clearly defined the learning path/graph and each subsection is associated with one or two teams max.

@AugustinMauroy
Copy link
Member

I've added it to the agenda to get their opinion on the matter.

@marco-ippolito
Copy link
Member

No problem with adding @nodejs/typescript as codeowner of the typescript related content for review

@AugustinMauroy
Copy link
Member

ping @nodejs/test_runner to move forward on this issue

@pmarchini
Copy link
Member

Hey @AugustinMauroy, no problem for me regarding @nodejs/test_runner.
I'd suggest collecting some thoughts from @cjihrig, @MoLow, @atlowChemi, and @jakecastelli as well.

@JakobJingleheimer
Copy link
Member

ping @nodejs/test_runner to move forward on this issue

I'm happy to do, although I'm not as active an implementer as Chemi, Colin, and Moshe.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 12, 2025

I'm not quite sure what is being asked of me in this issue? I think using the test_runner team as CODEOWNERS is fine if that's the question. It's worth noting though that none of the subsystem specific teams actually represent expertise in that subsystem. It just means that those people have subscribed to notifications.

@AugustinMauroy
Copy link
Member

It just means that those people have subscribed to notifications.

And have to approve PRs

@pmarchini
Copy link
Member

pmarchini commented Jan 12, 2025

It just means that those people have subscribed to notifications.

And have to approve PRs

In Node Core, being part of the team does not grant any particular ownership.
It simply provides an easier way to manage notifications.
As far as I know, a team member's approval doesn't have any specific effect @AugustinMauroy.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 12, 2025

Node core actually looked into leveraging CODEOWNERS years ago. That was exactly the problem though. Any collaborator can join any team and approve things... which defeats the whole purpose of CODEOWNERS.

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Jan 12, 2025

Node core actually looked into leveraging CODEOWNERS years ago. That was exactly the problem though. Any collaborator can join any team and approve things... which defeats the whole purpose of CODEOWNERS.

That another question. IDK if there are a way to disable self joining team. EDIT: we cannot "join as it" we can request to join. IDK who approve that but there are a step before joining any team

But for now we need someone that take care of nodejs learn content and it's why we use CODEOWNERS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
learn Issues/pr concerning the learn section
Projects
None yet
Development

No branches or pull requests

6 participants