Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: ShareX.ShareX does not close to update #210545

Open
2 tasks done
tranquilcarbon opened this issue Jan 11, 2025 · 1 comment
Open
2 tasks done

[Package Issue]: ShareX.ShareX does not close to update #210545

tranquilcarbon opened this issue Jan 11, 2025 · 1 comment
Labels
Area-External Installer-Issue Issue with the package's installer. Needs-Author-Feedback This needs a response from the author. Package-Metadata

Comments

@tranquilcarbon
Copy link

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

When attempting to update ShareX.ShareX, the update will fail, because ShareX updates expect the user to close the program. A message box appears, asking if the user wants to close it, but is dismissed, resulting in a failure.

Steps to reproduce

  1. Update ShareX.ShareX
  2. The update fails, because Winget cancels the box that asks if it wants to close.

Actual behavior

The following is written as a log:

2025-01-11 07:42:10.480   Setup version: Inno Setup version 6.3.3
2025-01-11 07:42:10.480   Original Setup EXE: C:\Users\Admin\AppData\Local\Temp\WinGet\ShareX.ShareX.17.0.0\ShareX-17.0.0-setup.exe
2025-01-11 07:42:10.480   Setup command line: /SL5="$20AFC,44445897,845824,C:\Users\Admin\AppData\Local\Temp\WinGet\ShareX.ShareX.17.0.0\ShareX-17.0.0-setup.exe" /SPAWNWND=$10AAA /NOTIFYWND=$D0A64 /SP- /VERYSILENT /SUPPRESSMSGBOXES /NORESTART /LOG="C:\Users\Admin\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-ShareX.ShareX.17.0.0-2025-01-11-07-42-06.799.log" /NORUN /UPDATE
2025-01-11 07:42:10.480   Compatibility mode: Yes (DetectorsAppHealth Installer)
2025-01-11 07:42:10.480   Windows version: 10.0.22631
2025-01-11 07:42:10.480   Windows architecture: x64 (64-bit)
2025-01-11 07:42:10.480   Machine types supported by system: x86 x64
2025-01-11 07:42:10.480   User privileges: Administrative
2025-01-11 07:42:10.484   Administrative install mode: Yes
2025-01-11 07:42:10.484   Install mode root key: HKEY_LOCAL_MACHINE
2025-01-11 07:42:10.484   64-bit install mode: Yes
2025-01-11 07:42:10.485   Created protected temporary directory: C:\Users\Dylan\AppData\Local\Temp\is-R4RL7.tmp
2025-01-11 07:42:10.494   Defaulting to Cancel for suppressed message box (OK/Cancel):
                          Setup has detected that ShareX is currently running.
                          
                          Please close all instances of it now, then click OK to continue, or Cancel to exit.
2025-01-11 07:42:10.494   Got EAbort exception.
2025-01-11 07:42:10.494   Deinitializing Setup.
2025-01-11 07:42:10.497   Log closed.

Expected behavior

Winget should send the signal for ShareX to close to begin the update.

Environment

Windows: Windows.Desktop v10.0.22631.4602
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.25200.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                E:\Downloads

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled

Screenshots and Logs

WinGet-ShareX.ShareX.17.0.0-2025-01-11-07-42-06.799.log
WinGet-2025-01-11-07-41-48.156.log

@tranquilcarbon tranquilcarbon added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jan 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 11, 2025
@Trenly
Copy link
Contributor

Trenly commented Jan 11, 2025

By design WinGet does not close running applications when performing updates to ensure that any unsaved data is not lost, and so that if an enterprise policy or a scheduled task is running the update in the background that it does not unexpectedly interrupt whatever you are working on / doing.

Therefore, the only way to accomplish this would be if the installer for the application supports closing the application on its own

@microsoft-github-policy-service microsoft-github-policy-service bot added Installer-Issue Issue with the package's installer. Area-External Needs-Author-Feedback This needs a response from the author. Package-Metadata and removed Needs-Triage This work item needs to be triaged by a member of the core team. Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External Installer-Issue Issue with the package's installer. Needs-Author-Feedback This needs a response from the author. Package-Metadata
Projects
None yet
Development

No branches or pull requests

2 participants