Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to parse targets from a targets.log and not via "make -pRrq" #522

Open
andreeis opened this issue Oct 23, 2023 · 1 comment
Open

Able to parse targets from a targets.log and not via "make -pRrq" #522

andreeis opened this issue Oct 23, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@andreeis
Copy link
Contributor

Mentioned in #217.
Like we can parse for IntelliSense from a build.log and not invoke "make --dry-run", we should offer the same possibility to parsing targets: via a given "targets.log" and not by "make -pRrq".

@drok
Copy link
Contributor

drok commented Oct 24, 2023

The build log "feature" was originally conceived as a workaround for non-working --dry-run. It should have been a temporary hack, because:

  1. build logs contain old, probably outdated info.
  2. Relying on build logs delegates the responsibility for updating these files to the end user, who is not necessarily a developer of the project, and not in a good position to take on this responsibility.
  3. It adds unnecessary configuration complexity (from the end-user's perspective: WTF is a "build log"?)

The same logic applies to "target logs". Please don't make them into a "feature".

I suggest committing to remove this workaround. Take responsibility for a working, reliable --dry-run. I've already proposed #500. Further, I think time spent on maintaining the workaround rather working on actual deficiencies of this extension is time wasted. Please kill build logs with 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants