Add tiktoken as a dependency in pyproject.toml #5008
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JohanForngren , Thanks for this fix. "autogen-ext[magentic-one, openai, azure]==0.4.0"This will install dependencies that we do need in Studio . See here Do you mind updating your fix to just modify the extras on autogen ext? ie this "autogen-ext[magentic-one, openai, azure]==0.4.0"Thanks again for testing and proposing this fix! |
JohanForngren
added a commit
to JohanForngren/autogen
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Johan Forngren <[email protected]>
JohanForngren
added a commit
to JohanForngren/autogen
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Johan Forngren <[email protected]>
JohanForngren
force-pushed
the
bug-5007-missing-tiktoken-dependency
branch
from
ef93f9e to
b5ca6ad
Compare
JohanForngren
added a commit
to JohanForngren/autogen
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Johan Forngren <[email protected]>
JohanForngren
force-pushed
the
bug-5007-missing-tiktoken-dependency
branch
from
b5ca6ad to
312717f
Compare
|
@victordibia Thank you, I updated the fix and tested it to verify that it's working. The @microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5008 +/- ##
=======================================
Coverage 68.50% 68.50%
=======================================
Files 156 156
Lines 10129 10129
=======================================
Hits 6939 6939
Misses 3190 3190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jackgerrits
approved these changes
Jan 13, 2025
Signed-off-by: Johan Forngren <[email protected]> Update uv.lock with tiktoken dependency from fbfdc9f Signed-off-by: Johan Forngren <[email protected]>
Signed-off-by: Johan Forngren <[email protected]>
JohanForngren
force-pushed
the
bug-5007-missing-tiktoken-dependency
branch
from
312717f to
5b59430
Compare
victordibia
approved these changes
Jan 13, 2025
victordibia
added a commit
that referenced
this pull request
Jan 15, 2025
* Add tiktoken as a dependency in pyproject.toml Signed-off-by: Johan Forngren <[email protected]> Update uv.lock with tiktoken dependency from fbfdc9f Signed-off-by: Johan Forngren <[email protected]> * Updating autogen-ext dependencies per #5008 (comment) Signed-off-by: Johan Forngren <[email protected]> * PoC dev container Signed-off-by: Johan Forngren <[email protected]> * Enhance devcontainer setup with post-create script for dependency installation and improved performance. Removed partial hot reload setup, as it required bigger changes to the project. Improved documentation, and fixed markdown lint issues. Signed-off-by: Johan Forngren <[email protected]> * Update installation documentation for AutoGen Studio, clarifying installation methods and improving formatting. Adjusted notes for Windows users and corrected minor grammatical issues. Signed-off-by: Johan Forngren <[email protected]> * Fixing typos. Restructuring text to avoid consecutive markdown quote blocks separated only by a blank line to avoid MD028 - Blank line inside blockquote. Signed-off-by: Johan Forngren <[email protected]> * Include dev containers tutorial Signed-off-by: Johan Forngren <[email protected]> * Update dev container installation instructions Signed-off-by: Johan Forngren <[email protected]> --------- Signed-off-by: Johan Forngren <[email protected]> Co-authored-by: Victor Dibia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding missing dependency tiktoken.
Related issue number
Closes #5007
Checks