Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization and other minor fixes, updated docs for setup commands #1282

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Serialization and other minor fixes, updated docs for setup commands #1282

wants to merge 5 commits into from

Conversation

charithabandi
Copy link
Contributor

No description provided.

This was linked to issues Jan 23, 2025
kwild setup init -r ./out does not print anything #1257
Open
Genesis config allocs does not accept Ethereum addresses #1259
Open
@charithabandi charithabandi marked this pull request as ready for review January 24, 2025 20:43
@charithabandi charithabandi linked an issue Jan 24, 2025 that may be closed by this pull request
kwild setup init should give info on allocs #1258
Open
jchappelow
jchappelow reviewed Jan 24, 2025
View reviewed changes
app/setup/genesis.go Outdated Show resolved Hide resolved
jchappelow
jchappelow reviewed Jan 24, 2025
View reviewed changes
app/snapshot/create.go Outdated Show resolved Hide resolved
jchappelow
jchappelow reviewed Jan 24, 2025
View reviewed changes
app/snapshot/create.go Outdated Show resolved Hide resolved
jchappelow
jchappelow reviewed Jan 24, 2025
View reviewed changes
app/snapshot/create.go Outdated Show resolved Hide resolved
jchappelow
jchappelow previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great changes here! Just a few concerns about the app commands having some implicit coupling and hard to maintain code, but otherwise fine.

@brennanjl
Copy link
Collaborator

Will wait for @jchappelow to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchappelow jchappelow jchappelow left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@charithabandi @brennanjl @jchappelow