Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Rethink VoteStore and the ValidatorSet management #1216

Open
charithabandi opened this issue Jan 13, 2025 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@charithabandi
Copy link
Contributor

charithabandi commented Jan 13, 2025

Potential Changes:

  • Clear boundaries on who can create resolutions. VoteStore inherently assumes that only voters can create resolutions, but Validator Joins break that rule where a non-validator is a proposer of the join resolution, which is okay, but the internal code should correctly handle these scenarios.
  • Decouple Voters from the VoteStore and let consensus engine manage Validators along with other consensus params and make VoteStore the Consumer of the Validator Set rather than the manager.
@charithabandi charithabandi added the enhancement New feature or request label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant