Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up stale CnsVolumeOperationRequest instances should only be done on one controller #3145

Open
sathieu opened this issue Dec 20, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sathieu
Copy link

sathieu commented Dec 20, 2024

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

Cleaning up stale CnsVolumeOperationRequest instances can be a intensive operation on cluster with a lot of CnsVolumeOperationRequest.

Currenlty this goroutine is run on all controllers, i.e 3 instances by default.

What you expected to happen:

Only the controller holding a lease should do this operation.

How to reproduce it (as minimally and precisely as possible):

Run:

kubectl rollout restart -n vsphers-csi deployment vsphere-csi-controller

Then look at the logs, you'll see on all 3 instances:

Cleaning up stale CnsVolumeOperationRequest instances.

Anything else we need to know?:

Environment:

  • csi-vsphere version: 3.3.1 vanilla
  • vsphere-cloud-controller-manager version: N/1
  • Kubernetes version: 1.30.3
  • vSphere version: 8.0
  • OS (e.g. from /etc/os-release): Debian
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants