Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DomainNames Egress Peer in ANP API #32

Open
tssurya opened this issue Jun 4, 2024 · 3 comments
Open

Implement DomainNames Egress Peer in ANP API #32

tssurya opened this issue Jun 4, 2024 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tssurya
Copy link

tssurya commented Jun 4, 2024

  1. We would love kube-network-policies to implement https://network-policy-api.sigs.k8s.io/npeps/npep-133-fqdn-egress-selector/
  2. This API NPEP merged last week AND we will soon have the API merged and we don't yet have any implementations
  3. So its also hard to write conformance tests without a testing driver backend

API Details:

So implementing it here will help us make it part of our upstream CI tests.

@aojea aojea added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 4, 2024
@tssurya
Copy link
Author

tssurya commented Jun 4, 2024

@rahulkjoshi : The API PR will follow soon right?

@vaskozl
Copy link
Contributor

vaskozl commented Jun 21, 2024

Got a few questions about the NPEP:

If a policy is applied after a lookup is already performed and cached by the client, is the implementor required to allow the traffic based on the past query?

Cilium's implementation forces you to specify matchPattern: "*" which explicitly caches all dns on port 53, or otherwise blocks DNS queries if matched with toFQDN (unlike the NPEP requirement) which ensures that an old lookup is not used.

The other thing that's not super clear is what DNS traffic is expected to be detected:

  • Should DNS lookups on ports other than 53 be supported?
  • Should other traffic on the dns port flow unhindered?

@aojea
Copy link
Contributor

aojea commented Aug 18, 2024

  • This API NPEP merged last week AND we will soon have the API merged and we don't yet have any implementations

@tssurya please ping me once the API PR is ready for review so we can give feedback from the implementation during the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants