Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor dependencies #763

Open
kannon92 opened this issue Jan 24, 2025 · 4 comments
Open

Vendor dependencies #763

kannon92 opened this issue Jan 24, 2025 · 4 comments

Comments

@kannon92
Copy link
Contributor

I notice that Kueue vendors their dependencies. They found that it helped speed up the build system.

I'd like to propose that we vendor also so that we are consistent with kueue and we can gain some benefits of builds.

kubernetes-sigs/kueue#2374

@ahg-g
Copy link
Contributor

ahg-g commented Jan 25, 2025

I am not sure if this is needed, what we currently have works and the build time is not a major issue here.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 25, 2025

I just don't want to unnecessarily introduce new sources of errors/problems

@kannon92
Copy link
Contributor Author

I'm unclear on the motivation for Kueue.

From the kueue issue,

We are trying to build images in a different infrastructure that requires vendoring the dependencies.

I can attest that a lot of build tooling for FIPS really wants vendored dependencies. I can ask around to see if this is a requirement for FIPS or just a nice to have.

@andreyvelich
Copy link
Contributor

I agree with @ahg-g, and I added my thoughts here: #764 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants