Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade klog to v2 #2469

Closed
Electronic-Waste opened this issue Jan 7, 2025 · 6 comments · Fixed by #2470
Closed

Upgrade klog to v2 #2469

Electronic-Waste opened this issue Jan 7, 2025 · 6 comments · Fixed by #2470
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@Electronic-Waste
Copy link
Member

Electronic-Waste commented Jan 7, 2025

What you would like to be added?

I would like to upgrade klog version to v2

Why is this needed?

As we discussed in #2463 (comment), a dedicated issue for upgrading klog version is needed.

And also, we rely on both v1 and v2 version, which is not neat enough and may need to be unified into the same version.

katib/go.mod

Line 30 in 3363964

k8s.io/klog v1.0.0

katib/go.mod

Line 153 in 3363964

k8s.io/klog/v2 v2.110.1 // indirect

cc👀 @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit @Doris-xm

/remove-label lifecycle/needs-triage
/help-wanted
/good-first-issue

Love this feature?

Give it a 👍 We prioritize the features with most 👍

Copy link

@Electronic-Waste:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What you would like to be added?

I would like to upgrade klog version to v2

Why is this needed?

As we discussed in #2463 (comment), a dedicated issue for upgrading klog version is needed.

And also, we rely on both v1 and v2 version, which is not neat enough and may need to be unified into the same version.

katib/go.mod

Line 30 in 3363964

k8s.io/klog v1.0.0

katib/go.mod

Line 153 in 3363964

k8s.io/klog/v2 v2.110.1 // indirect

cc👀 @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit @Doris-xm

/remove-lifecycle needs-triage
/help-wanted
/good-first-issue

Love this feature?

Give it a 👍 We prioritize the features with most 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 7, 2025
@Electronic-Waste
Copy link
Member Author

/remove-label lifecycle/needs-triage

@Doris-xm
Copy link
Contributor

Doris-xm commented Jan 7, 2025

I'd like to help with this issue, could you assign it to me?

@Electronic-Waste
Copy link
Member Author

Yeah, of course! Feel free to assign it to yourself.

/assign @Doris-xm

@Electronic-Waste
Copy link
Member Author

Electronic-Waste commented Jan 7, 2025

FYI, you can check this PR for upgrading klog v2 version: kubeflow/training-operator#2332

Now, we are upgrading the Kubernetes version (#2463) so it would be better to make klog version consistent to the corresponding Kubernetes version.

@Doris-xm Doris-xm mentioned this issue Jan 7, 2025
1 task
@Electronic-Waste
Copy link
Member Author

/release 0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants