Buffer reusal in the BufferingResponseListener

[wendigo]

Jetty version(s)
12.x

Enhancement Description

Is it possible for the BufferingResponseListener to accept ByteBufferPool to reuse buffers instead of allocating them per request?

[sbordet]

@wendigo definitely a good to have.

[sbordet]

@wendigo this might be trickier than expected.

The default max size for BufferingResponseListener is 2 MiB.

The default max capacity for ArrayByteBufferPool is 64 KiB.

If the response content is within 64 KiB, then the ByteBuffer is pooled, otherwise the pool will just allocate it on-the-fly like BufferingResponseListener is doing right now.

So yes, there is a benefit for small content, but for larger content you need to size the ArrayByteBufferPool max capacity accordingly.

[wendigo]

@sbordet that's why in the PR i've posted I've used NonPooled one to make it compatible with the current implementation. For the pooled usage, the consumer should be responsible for providing a pool that actually pools