-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛] Eas build failure with UnsupportedModulePropertyParserError (workaround: use react-native 0.76+ / expo 52+) #678
Comments
and Expo 51 Could you update to current versions and re-test? Logging issues against old versions frequently has us chasing ghosts as issues are already fixed and you just need to update May not be the case, but may be the case and we don't have any time to chase fixed isses Thanks |
I'm experiencing the same issue. Could you clarify what update you mean? This is the latest version of the package @mikehardy |
DId you fix the issue sir? @ChristopherBanas |
Current react-native, current expo |
I did update them and I have these versions currently and still having the same issue when building this is my react native and expo version |
expo 52, react-native 76.x are current @RobertoJoseph |
It works after updating, thanks sir! @mikehardy |
I have the same issue after pod install. |
@mohammadmas1988 I expect you will have the same success after updating to current react-native, which is what the new Native Ads feature was built and tested with. We should support previous react-native versions but I think all of your friendly volunteers here are on holiday so unless someone posts a PR for compatibility, you'll have to upgrade your react-native to get the current react-native-google-mobile-ads version to work, or you'll need to stay on prior versions of react-native-google-mobile-ads. |
This comment was marked as resolved.
This comment was marked as resolved.
Please read the comment thread carefully. |
Hey @mikehardy thanks for the tips. Been needing to do an expo update. That did solve my issue, but it led to another eas build issue.
Here is my
All other configurations are the same as I listed in the original issue message. I tried doing a |
🤔 that version for the underlying native SDK looks suspicious - looks like you are trying to use the version of this react-native module as the version for the native SDK, which is a separate thing with it's own version train, based on the version being the same as our react-native module:
whereas in cocoapods it is v11.13.0 https://cocoapods.org/pods/Google-Mobile-Ads-SDK And we define 11.13.0 as well
You have done something wrong with an override of the version I think @ChristopherBanas - in your Podfile. You should investigate and you will likely find that you have specified a version and it is wrong ? react-native-google-mobile-ads/RNGoogleMobileAds.podspec Lines 58 to 61 in b632819
|
@mikehardy thanks for all of this! Will double check everything now. I am using expo so the pod files should be abstracted from me but let me see |
@mikehardy Thanks a lot! Expo version was problem. What I Did
Referencehttps://docs.expo.dev/workflow/upgrading-expo-sdk-walkthrough/ Reference2
{
"name": "app",
"main": "expo-router/entry",
"version": "1.0.0",
"scripts": {
"start": "expo start",
"reset-project": "node ./scripts/reset-project.js",
"android": "expo run:android",
"ios": "expo run:ios --device 'iPhone 16'",
"ios2": "expo run:ios --device 'iPhone 16 Pro'",
"web": "expo start --web",
"test": "jest --watchAll",
"lint": "expo lint"
},
"jest": {
"preset": "jest-expo"
},
"dependencies": {
"@expo/vector-icons": "^14.0.2",
"@gorhom/bottom-sheet": "^5",
"@ptomasroos/react-native-multi-slider": "^2.2.2",
"@react-native-async-storage/async-storage": "1.23.1",
"@react-native-community/datetimepicker": "8.2.0",
"@react-native-community/slider": "4.5.5",
"@react-native-firebase/analytics": "^21.6.1",
"@react-native-firebase/app": "^21.6.1",
"@react-native-firebase/auth": "^21.6.1",
"@react-native-firebase/firestore": "^21.6.1",
"@react-native-firebase/storage": "^21.6.1",
"@react-native-google-signin/google-signin": "^13.1.0",
"@react-navigation/native": "^7.0.14",
"date-fns": "^4.1.0",
"expo": "^52.0.23",
"expo-apple-authentication": "~7.1.2",
"expo-auth-session": "~6.0.1",
"expo-build-properties": "~0.13.1",
"expo-constants": "~17.0.3",
"expo-font": "~13.0.2",
"expo-image-picker": "~16.0.3",
"expo-linear-gradient": "~14.0.1",
"expo-linking": "~7.0.3",
"expo-router": "~4.0.15",
"expo-splash-screen": "~0.29.18",
"expo-status-bar": "~2.0.0",
"expo-system-ui": "~4.0.6",
"expo-web-browser": "~14.0.1",
"firebase": "^10.14.0",
"jotai": "^2.10.4",
"react": "18.3.1",
"react-dom": "18.3.1",
"react-native": "0.76.5",
"react-native-date-picker": "^5.0.7",
"react-native-element-dropdown": "^2.12.1",
"react-native-gesture-handler": "~2.20.2",
"react-native-google-mobile-ads": "^14.8.0",
"react-native-iap": "^12.15.7",
"react-native-paper": "^5.12.5",
"react-native-reanimated": "~3.16.1",
"react-native-safe-area-context": "4.12.0",
"react-native-screens": "~4.4.0",
"react-native-table-component": "^1.2.2",
"react-native-toast-message": "^2.2.1",
"react-native-vertical-slider": "^1.0.1",
"react-native-video": "^6.8.2",
"react-native-web": "~0.19.13",
"react-native-webview": "13.12.5"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@types/jest": "^29.5.12",
"@types/react": "~18.3.12",
"@types/react-test-renderer": "^18.0.7",
"jest": "^29.2.1",
"jest-expo": "~52.0.2",
"react-test-renderer": "18.2.0",
"typescript": "~5.3.3"
},
"private": true
} |
Got the error while upgrading from Expo 50 to Expo 51.
As far as I understand the error occurs because TurboModule interfaces only support functions as properties (in the react-native version used in 51). @wjaykim any ideas how to fix? |
Hmm... The |
Also, above android build error mentioned in #684 is caused by new Maybe we have to add compatibility layer or mark the change as breaking? |
@wjaykim would be great if we could add a compatibility layer. |
Update on this. Running this locally was causing my builds to fail with the issue I linked. When I did it on remotely (not with |
I’m experiencing the same issue with Expo SDK 51 and react-native-google-mobile-ads (version 14.2.0). The builds for both Android and iOS suddenly stopped working, even though no changes were made to the code or configuration. |
@M4rcoToni ..... which matches exactly what this issue describes. And there's a known workaround of either not updating to the version with native ads that is inadvertently breaking, or upgrading your Expo. So did you do that? And did it work? |
Updated codes to include generated native code by codegen(Reference: https://reactnative.dev/docs/the-new-architecture/codegen-cli#including-generated-code-into-libraries). By doing this, as the generated code is always included in npm artifact(and not rely on the app to run codegen for us), we can support lower react native(or @react-native/codegen) version. Also removed unnecessary constructor passing contexts in classes extending ViewGroupManager, which breaks build in rn version lower than 0.75. Fixes #678
I am getting
I am on the latest version of Expo and react-native that comes with it.
The exact same code works on Pixel 2 with Android 11, the crash happens on Android 8. Is this related to the new Native Ad support? |
Switching back to
Solves the crash for me. |
maybe submit a new issue? this issue is turning into a catch all for a lot of unrelated issues |
@mikehardy do you think we can close this issue? the specific one I had has been solved and you gave good explanations on how to fix it |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm going to leave this open because people should know it is still an issue even if there is a workaround. If you can use react-native 0.76+ (which implies Expo 52+) - great! It will work. If you must use react-native 0.75 or lower (that is, Expo 51 or lower) then your build will break with react-native-google-mobile-ads 14.8.0+ You must not use anything newer than 14.7.2 until we either make it backwards compatible or you can upgrade react-native. (note: we plan to issue a 14.8.1 that reverts native ads then re-issue as v15.0.0 to clearly mark the semantic version break, and I/we are sorry that 14.8.0 inadvertently broke older react-native versions. We understand it isn't great. We haven't had time to do this yet though, apologies) |
What happened?
I was going through the setup instructions outlined here for my expo app and once I got to rebuilding my app using eas, I was met with the following error
The steps I did to get to here were
npx expo install react-native-google-mobile-ads
eas build --profile development-simulator --platform ios --local
to generate a new buildPlatforms
iOS, but have not tested behavior on Android
React Native Info
Are your using Typescript?
package.json
app.json
ios/Podfile
No response
android/build.gradle
No response
android/app/build.gradle
No response
android/settings.gradle
No response
AndroidManifest.xml
No response
The text was updated successfully, but these errors were encountered: