Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework plugins so that it's only triggers #25876

Closed
pauldix opened this issue Jan 21, 2025 · 0 comments · Fixed by #25914
Closed

Rework plugins so that it's only triggers #25876

pauldix opened this issue Jan 21, 2025 · 0 comments · Fixed by #25914
Assignees
Labels

Comments

@pauldix
Copy link
Member

pauldix commented Jan 21, 2025

Now that plugins come from either the local disk or Github, it's no longer necessary to have a plugin creation step separate from a trigger creation step. We can just create the trigger. I propose:

influxdb3 create trigger --plugin <path/foo/file.py> --type <wal|schedule|request|persist> --spec <the trigger spec> --arguments <comma separated k/v list>

The plugin part will either be a path to a file in the plugin dir, or start with gh: in which case it's to be found in the plugin repo in github.

All of the plugin commands should be removed.

It should still be possible to enable and disable triggers.

@pauldix pauldix added the v3 label Jan 21, 2025
@pauldix pauldix self-assigned this Jan 23, 2025
pauldix added a commit that referenced this issue Jan 25, 2025
This refactors plugins and triggers so that plugins no longer need to be "created". Since plugins exist in either the configured local directory or on the Github repo, a user now only needs to create a trigger and reference the plugin filename.

Closes #25876
pauldix added a commit that referenced this issue Jan 25, 2025
This refactors plugins and triggers so that plugins no longer need to be "created". Since plugins exist in either the configured local directory or on the Github repo, a user now only needs to create a trigger and reference the plugin filename.

Closes #25876
pauldix added a commit that referenced this issue Jan 26, 2025
This refactors plugins and triggers so that plugins no longer need to be "created". Since plugins exist in either the configured local directory or on the Github repo, a user now only needs to create a trigger and reference the plugin filename.

Closes #25876
pauldix added a commit that referenced this issue Jan 26, 2025
This refactors plugins and triggers so that plugins no longer need to be "created". Since plugins exist in either the configured local directory or on the Github repo, a user now only needs to create a trigger and reference the plugin filename.

Closes #25876
pauldix added a commit that referenced this issue Jan 26, 2025
This refactors plugins and triggers so that plugins no longer need to be "created". Since plugins exist in either the configured local directory or on the Github repo, a user now only needs to create a trigger and reference the plugin filename.

Closes #25876
pauldix added a commit that referenced this issue Jan 27, 2025
This refactors plugins and triggers so that plugins no longer need to be "created". Since plugins exist in either the configured local directory or on the Github repo, a user now only needs to create a trigger and reference the plugin filename.

Closes #25876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant