Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated APIs #1453

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Remove deprecated APIs #1453

merged 5 commits into from
Nov 6, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Nov 5, 2024 •
edited
Loading

Context

  • remove binarySearchThreshold config option
  • remove ValueCellVertex.setCellValue method (It wasn't exposed as public API and it didn't work since version 0.5.0)
  • add changelog entry
  • add migration guide
  • remove mentions of the removed APIs from the docs

How did you test your changes?

unit tests pass

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1439

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba added the Breaking Change Will need a major release label Nov 5, 2024
@sequba sequba self-assigned this Nov 5, 2024
@sequba sequba linked an issue Nov 5, 2024 that may be closed by this pull request
Remove deprecated APIs #1439
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Performance comparison of head (2b4e6ad) vs base (096aadf)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 523.85 | 521.62 | -0.43%
                                      Sheet B | 174.91 | 175.19 | +0.16%
                                      Sheet T | 150.23 | 149.92 | -0.21%
                                Column ranges | 522.38 | 519.27 | -0.60%
Sheet A:  change value, add/remove row/column |  15.12 |  14.54 | -3.84%
 Sheet B: change value, add/remove row/column | 141.24 | 140.07 | -0.83%
                   Column ranges - add column | 158.47 | 158.56 | +0.06%
                Column ranges - without batch | 457.65 |    458 | +0.08%
                        Column ranges - batch | 111.45 |  114.9 | +3.10%

@sequba sequba requested a review from budnix November 6, 2024 12:34
budnix
budnix approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left one comment to consider.

src/Config.ts Show resolved Hide resolved
@sequba sequba merged commit 34d0a37 into develop Nov 6, 2024
21 of 22 checks passed
@sequba sequba deleted the feature/issue-1439 branch November 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnix budnix budnix approved these changes

Assignees

@sequba sequba

Labels
Breaking Change Will need a major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated APIs
2 participants
@sequba @budnix