Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python language: issue on github showing code navigation of instance variables #531

Closed
amaajemyfren opened this issue Apr 6, 2020 · 1 comment

Comments

@amaajemyfren
Copy link

Hi,

Preamble and caveats

I do not know Haskell or how to use semantic - I just saw here that github uses semantic and so had an issue (really small issue and thought to raise it in case you could know how to fix it. Feel free to ignore this and close this issue if it does not make sense - or if it is an issue of how github has implemented it.

Also while I have read #57 and that may be where this is addressed but it is not clear to me.

The actual issue:

Take this file. More specifically look here

These are instance variables being initialised in the class (within the dunder method init). As such they are the definitions of the variables.

e.g. take the definition self.indent = indent When you highlight it and click the first indent you get:
image
All those indent references are functions in other files - completely unrelated to this indent. This is in fact the definition of the indent. More annoyingly the second indent comes from the method init and not where it suggests it comes from now:
image

Also the other variables above it (self.skipkeys, self.ensure_ascii, self.check_circular, self.allow_nanandself.sort_keys`) all do not have code navigations and they should. They are all the definitions and they should also refer to the init method.

Thanks.

@patrickt
Copy link
Contributor

patrickt commented Apr 6, 2020

Hi there. This is indeed a bug, one that semantic doesn't handle correctly right now; since this relates to a GitHub feature directly, I'm closing this and moving it to our internal repository tracking code navigation issues. Thank you for the report!

@patrickt patrickt closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants