Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(nav): Create new NavContextProvider that wraps the entire application #83615

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

malwilley
Copy link
Member

The first step towards making this component more reusable is creating a new context that will be available anywhere in the app. Don't need any of the existing logic, so I'm creating a new one entirely. Will delete the old when read to switch over entirely.

@malwilley malwilley requested a review from a team January 16, 2025 22:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 16, 2025
Copy link

codecov bot commented Jan 17, 2025

Bundle Report

Changes will increase total bundle size by 31.29MB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
app-webpack-bundle-array-push 31.29MB 31.29MB (100%) ⬆️⚠️

@malwilley malwilley merged commit eb70f2a into master Jan 17, 2025
42 checks passed
@malwilley malwilley deleted the malwilley/feat/nav-context-move branch January 17, 2025 18:15
Copy link

sentry-io bot commented Jan 22, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'width') /issues View Issue
  • ‼️ TypeError: Cannot destructure property 'statusText' of 'dt[t.status]' as it is undefined. /alerts/rules/ View Issue
  • ‼️ TypeError: Cannot destructure property 'statusText' of 'lt[t.status]' as it is undefined. /alerts/rules/ View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
…tion (#83615)

The first step towards making this component more reusable is creating a
new context that will be available anywhere in the app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants