Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View Hierarchy absolute positioning should be dependent on rendering_system rather than project.platform #83291

Open
timfish opened this issue Jan 11, 2025 · 1 comment · May be fixed by #83292
Open

View Hierarchy absolute positioning should be dependent on rendering_system rather than project.platform #83291

timfish opened this issue Jan 11, 2025 · 1 comment · May be fixed by #83292
Labels
Product Area: Issues Waiting for: Product Owner

Comments

@timfish
Copy link
Contributor

timfish commented Jan 11, 2025

Problem Statement

Currently, the only way to enable absolute positioning for the View Hierarchy wireframe, is to choose a specific project type:

sentry/static/app/components/events/viewHierarchy/utils.tsx

Lines 44 to 47 in 5f9a15d

export function getHierarchyDimensions(
hierarchies: ViewHierarchyWindow[],
useAbsolutePosition: boolean = false
): {

sentry/static/app/components/events/viewHierarchy/wireframe.tsx

Lines 51 to 54 in 5f9a15d

getHierarchyDimensions(
hierarchy,
['flutter', 'dart-flutter'].includes(project?.platform ?? '')
),

This means there is currently no way to have absolute positioning outside of those project types.

Solution Brainstorm

Absolute positioning should be dependent on rendering_system. Maybe we should also check rendering_system.includes('absolute') so this can be overridden from the SDKs without having to update a list in Sentry?

We should also document this in the RFC. Currently it doesn't even mention absolute/relative positioning!

Product Area

Issues
@getsantry
Copy link
Contributor

getsantry bot commented Jan 11, 2025

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 11, 2025
@timfish timfish linked a pull request Jan 11, 2025 that will close this issue
Open
@timfish timfish changed the title View Hierarchy relative/absolute positioning should be dependent on rendering_system rather than project.platform View Hierarchy absolute positioning should be dependent on rendering_system rather than project.platform Jan 11, 2025
@timfish timfish mentioned this issue Jan 11, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Product Area: Issues Waiting for: Product Owner
Projects
GitHub Issues with 👀 3
Status: Waiting for: Product Owner
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use rendering_system to enable absolute positioning of view hierarchy wireframe timfish/sentry
1 participant
@timfish