Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abide by hideSourceMaps option in nextjs webpack config #13618

Closed
andreiborza opened this issue Sep 9, 2024 · 3 comments
Closed

Abide by hideSourceMaps option in nextjs webpack config #13618

andreiborza opened this issue Sep 9, 2024 · 3 comments
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK

Comments

@andreiborza
Copy link
Member

Description

See #13613

@andreiborza andreiborza changed the title Abide by hideSourceMaps option in webpack config Abide by hideSourceMaps option in nextjs webpack config Sep 9, 2024
@AbhiPrasad AbhiPrasad added the Package: nextjs Issues related to the Sentry Nextjs SDK label Sep 9, 2024
@cupofjoakim
Copy link

@andreiborza Is this not supported? I see it in the docs here: Link

The reason I found this thread is that we still get the reference to the map in our chunks even if the option is set.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 5, 2024
@lforst
Copy link
Member

lforst commented Dec 5, 2024

@cupofjoakim Hi, thanks for writing in. Seems like we slightly dropped the ball on this one with v8. The option is indeed in the docs and also in the type definitions but it doesn't do anything.

What should happen though by default in the SDK is that the client chunks should not have a source mapping URL at the bottom unless you set productionBrowserSourceMaps to true.

We'll update the typedefs by deprecating them and update the docs but can you potentially either confirm that you are using productionBrowserSourceMaps or would you mind providing a reproduction example? Thanks!

@s1gr1d
Copy link
Member

s1gr1d commented Dec 10, 2024

Closing this in favor of this: #13993

If no explicit user-setting is provided, we will enable source maps generation by setting hidden.

@s1gr1d s1gr1d closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK
Projects
Archived in project
Development

No branches or pull requests

5 participants