Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation manager translatable pivot attribute always updating on defaut locale #9054

Closed
alva-v opened this issue Oct 12, 2023 · 0 comments · Fixed by #10182
Closed

Relation manager translatable pivot attribute always updating on defaut locale #9054

alva-v opened this issue Oct 12, 2023 · 0 comments · Fixed by #10182
Labels
bug Something isn't working low priority unconfirmed
Milestone

Comments

@alva-v
Copy link
Contributor

alva-v commented Oct 12, 2023

Package

filament/filament

Package Version

v3.0.74

Laravel Version

v10.28.0

Livewire Version

v3.0.8

PHP Version

PHP 8.2.4

Problem description

I have created a relation manager.
The corresponding pivot table has a translatable attribute, made translatable with spatie/laravel-translable on its pivot model.
The Resource and RelationManager have been made translatable.
When updating the pivot attribute with the edit table action, the value is always updated for the default locale, regardless of the language selected with the relation manager locale switcher.

Expected behavior

The value should be updated for the locale selected in the relation manager locale switcher.

Steps to reproduce

git clone [email protected]:alva-v/filament-relation-manager-translatable-pivot-attribute.git

php artisan migrate --seed

php artisan make:filament-user
  • Go to /admin/login and log in
  • Go to /admin/foos/1/edit
  • Use the Bars relation manager locale switcher to change the language to french
  • In Bars relation manager, click on Edit
  • Modify the content of the Attribute input

Reproduction repository

https://github.com/alva-v/filament-relation-manager-translatable-pivot-attribute

Relevant log output

No response

@alva-v alva-v added bug Something isn't working low priority unconfirmed labels Oct 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Oct 12, 2023
@zepfietje zepfietje added this to the v3 milestone Oct 13, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority unconfirmed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants