Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when using ->reorderable() on KV fields inside Builder fields #9027

Closed
binaryfire opened this issue Oct 11, 2023 · 0 comments · Fixed by #10180
Closed

Exception when using ->reorderable() on KV fields inside Builder fields #9027

binaryfire opened this issue Oct 11, 2023 · 0 comments · Fixed by #10180
Labels
bug Something isn't working confirmed low priority
Milestone
v3

Comments

@binaryfire
Copy link
Contributor

binaryfire commented Oct 11, 2023 •
edited
Loading

Package

filament/filament

Package Version

3.0.73

Laravel Version

10.2.6

Livewire Version

3.0.7

PHP Version

8.2

Problem description

Using ->reorderable() on a key-value field inside a Builder field throws the following exception:

TypeError: Filament\Forms\Components\Builder::Filament\Forms\Components\{closure}(): Argument #1 ($itemData) must be of type array, int given

Video: https://www.youtube.com/watch?v=RSpddTRErvw

Expected behavior

Reordering kv options should work as expected

Steps to reproduce

Please see this vid for reproduction steps: https://www.youtube.com/watch?v=RSpddTRErvw

Reproduction repository

https://github.com/binaryfire/filament-kv-bug

Relevant log output

No response
@binaryfire binaryfire added bug Something isn't working low priority unconfirmed labels Oct 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Oct 11, 2023
@binaryfire binaryfire changed the title Error using ->reorderable() with KV fields inside Builder fields Error using ->reorderable() on KV fields inside Builder fields Oct 11, 2023
@binaryfire binaryfire changed the title Error using ->reorderable() on KV fields inside Builder fields Exception when using ->reorderable() on KV fields inside Builder fields Oct 11, 2023
@zepfietje zepfietje added this to the v3 milestone Oct 12, 2023
@danharrin danharrin mentioned this issue Dec 8, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed low priority
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging a pull request may close this issue.

fix: Keyval / tags input sort event filamentphp/filament
3 participants
@awcodes @binaryfire @zepfietje