Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Micro test optimization: Avoid loading unneeded datasets in EsqlSpecIT tests. #120022

Open
GalLalouche opened this issue Jan 12, 2025 · 1 comment
Open

ESQL: Micro test optimization: Avoid loading unneeded datasets in EsqlSpecIT tests. #120022

GalLalouche opened this issue Jan 12, 2025 · 1 comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement good first issue low hanging fruit low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests

Comments

@GalLalouche
Copy link
Contributor

Description

When trying to debug a single failing integration test, we can shave a few precious seconds each cycle by not loading datasets which are not used by any of the tests being run. Since we probably wish to avoid parsing the FROM clause, we can do this in two simple ways:

  1. A new statement for the csv-spec DSL, signifying which datasets are needed for the current test/the entire file (for BWC, this if this is missing we will of course assume all datasets are needed).
  2. A command line argument, signifying which datasets should be loaded by the test run.
@GalLalouche GalLalouche added :Analytics/ES|QL AKA ESQL >enhancement >test Issues or PRs that are addressing/adding tests good first issue low hanging fruit low-risk An open issue or test failure that is a low risk to future releases needs:triage Requires assignment of a team area label labels Jan 12, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Jan 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >enhancement good first issue low hanging fruit low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalLalouche @elasticsearchmachine