-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support raw Gradle repository names in the UI repository snippet card #2169
Comments
Hey, this is expected behaviour. Gradle does not have a concept of repository id, there's only a way to specify the name (that is optional, generated from URL by default). The name starts with lower case, because it's later on mapped to the command. Example: So in this case, even if it doesn't look so good, we're following the offical approach. |
That's quite unfortunate because that's not how Minecraft modders feel about this. All gradle repository examples in Minecraft modding capitalize the Maven ID, and that is the expected behavior in that context. Adding an option for an exception to disable the uncapitalization and repository appendix would be a good compromise. |
Sorry if I sound a little abrasive 😅; I'm not trying to be. I'll draft up a PR for this if that's okay. I don't suspect this would be a particularly hard feature to implement? |
As far as I know we have a decent number of mc related users, so I guess we could consider the alternative naming for Gradle repositories. Adding this should be fairly simple, but it involves conditional frontend changes, so we most likely need to introduce a new static variable: reposilite/reposilite-frontend/src/store/placeholders.js Lines 17 to 25 in 65dc935
In frontend settings we'd put something like opt-in "Disable default name formatting in UI", so later on, you can just bypass this impl with it:
|
What happened?
When setting the Reposilite Frontend's Maven ID, it automatically uncapitalizes the first character as seen below:
This is undesirable behavior for a professional setting as the capitalization denotes it is a proper noun.
Here is the Maven configuration for context:
Another side-effect is that the copy feature does not include the Maven ID.
Finally, my biggest gripe with this feature is that it includes the repository name in the Maven ID.
Reposilite version
3.x
Relevant log output
No response
The text was updated successfully, but these errors were encountered: