Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #12763 #12764

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix issue #12763 #12764

merged 1 commit into from
Jan 15, 2025

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Jan 12, 2025

Fixes #12763

Proposed changes

  • Use correct version of GetResourceString

Customer Impact

  • Labels in ProgressDialog will have correct values

Regression?

  • Yes

Risk

  • Minimal
Microsoft Reviewers: Open in CodeFlow

@paul1956 paul1956 requested a review from a team as a code owner January 12, 2025 07:16
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.18217%. Comparing base (2261fa0) to head (865ec3e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12764         +/-   ##
===================================================
+ Coverage   76.17780%   76.18217%   +0.00436%     
===================================================
  Files           3193        3193                 
  Lines         640306      640306                 
  Branches       47237       47237                 
===================================================
+ Hits          487771      487799         +28     
+ Misses        149008      148977         -31     
- Partials        3527        3530          +3     
Flag Coverage Δ
Debug 76.18217% <0.00000%> (+0.00436%) ⬆️
integration 18.15943% <0.00000%> (-0.00177%) ⬇️
production 50.11705% <0.00000%> (+0.00632%) ⬆️
test 97.02313% <ø> (+0.00280%) ⬆️
unit 47.54197% <0.00000%> (+0.00737%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit b148575 into dotnet:main Jan 15, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressDialog has wrong text for labels when used with DownloadFile
3 participants