Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we're surpressing ALL later handling of hotkeys, not just menu handling #87

Open
ceejbot opened this issue Dec 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ceejbot
Copy link
Owner

ceejbot commented Dec 7, 2023

The use case here is somebody wanting to bind shift-left-click to a HUD action, while not triggering the main game context left-click behavior. I suspect if I do this, I'm going to have to switch to acting on key-down instead of key-up, which is something I'm going to have to test carefully. It's a lot of long-standing code in the trickiest paths. OTOH, a third rewrite of that stuff will probably improve on the current implementation.

Take the approach here in the menu handler and apply it here in the gameplay key event handler when we know we did something with it. Also review the Rust-side handler logic to be sure it's returning the right thing every time, because until we make this change we won't have been relying on that being correct.

@ceejbot ceejbot added the enhancement New feature or request label Dec 7, 2023
ceejbot added a commit that referenced this issue Dec 18, 2023
Using the same technique as with menu button events: if
we handled it, we wipe out the event data so later processing
will skip it. This should address bug #87. Dry-coded; needs
testing.
@ceejbot
Copy link
Owner Author

ceejbot commented Dec 19, 2023

This is probably fixed, but I need to find a way to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant