Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not restrict CMAKE_MODULE_PATH to a single path #476

Open
vaavaav opened this issue Oct 30, 2024 · 0 comments
Open

Do not restrict CMAKE_MODULE_PATH to a single path #476

vaavaav opened this issue Oct 30, 2024 · 0 comments

Comments

@vaavaav
Copy link

vaavaav commented Oct 30, 2024

Right now, braft's CMakeLists.txt restricts CMAKE_MODULE_PATH to ${PROJECT_SOURCE_DIR}/cmake. However, this makes it harder to link braft against other libraries, since developers will have to copy Find<library>.cmake files to that path, which is impractical.

Instead, allow the user to provide other paths while still maintaining this one by changing that line to: list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake").

With this, developers can provide other paths where Find<library>.cmake files exist in the command line (for example, with cmake -DCMAKE_MODULE_PATH=opt/lib/cmake).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant