Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add CDK JSON context to override with json payload and update deploy from forked repo #691

Open
containeers opened this issue Jan 20, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@containeers
Copy link
Contributor

Describe the solution you'd like

Ability to simplify overriding multiple values in the cdk.json file by providing them as a JSON payload. This feature should allow users to upload a JSON string directly, which can then be used to override the existing cdk.json context during deployment.

Why the solution needed

Currently, adding multiple options to override the cdk.json file becomes cumbersome when passing arguments to a script. Supporting a JSON payload simplifies the process, reduces errors, and improves maintainability for developers.

Additional context

This feature could involve accepting an additional argument (e.g., a JSON string or file) in the deploy.yml workflow to handle the override seamlessly.

Implementation feasibility

Are you willing to collaborate with us to discuss the solution, decide on the approach, and assist with the implementation?

  • Yes, I am able to implement the feature and create a pull request.
@containeers
Copy link
Contributor Author

Sample Input to cloudformation(deploy.yml) with export value

export CDK_JSON_OVERRIDE='{
  "context": {
    "enableLambdaSnapStart": false,
    "anotherKey": "anotherValue"
  }
}'

Below code build command should be able to override the cdk.json
echo \"$CDK_JSON_OVERRIDE\" | jq '.' && jq --argjson override \"$CDK_JSON_OVERRIDE\" '. * $override' cdk/cdk.json > temp.json && mv temp.json cdk/cdk.json

@statefb statefb added enhancement New feature or request and removed needs-triage labels Jan 21, 2025
@statefb statefb self-assigned this Jan 21, 2025
@statefb
Copy link
Contributor

statefb commented Jan 21, 2025

@containeers This FR seems an advanced usage. Super-easy deployment which uses deploy.yml is designed for the very first user of bedrock-claude-chat, but we recommend CDK deployment if you wish to customize this solution. May I ask you the detailed backgrounds / contexts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants