Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why to remove WebkitWebExtensions? #3554

Open
shamazmazum opened this issue Jan 5, 2025 · 2 comments · May be fixed by #3562
Open

Why to remove WebkitWebExtensions? #3554

shamazmazum opened this issue Jan 5, 2025 · 2 comments · May be fixed by #3562
Labels
4-series Related to releases whose major version is 4. feature Feature requests.

Comments

@shamazmazum
Copy link
Contributor

shamazmazum commented Jan 5, 2025 •
edited
Loading

Why to remove the code which sets WebkitWebExtensions (.so ones) directory?

I currently use a default Nyxt in conjunction with blockit to block ads. Obviously, this is not possible with the original browser. Was the removal deliberate? Since Nyxt does not have its own ads blocker, this decision does not seem good for me.

Do you plan to bring it back anytime soon? Doing so it trivial, anyway.

UPD: I am complaining about master branch. 3.x.x are OK AFAIK
@shamazmazum shamazmazum added the feature Feature requests. label Jan 5, 2025
@aadcg
Copy link
Member

aadcg commented Jan 6, 2025

I am aware of blockit but never tried it myself with Nyxt. I deleted that piece since AFAIK it is one of the very few WebkitWebExtensions and I thought no one was using it.

Feel free to send a PR that reverts aafb5ad. Also, it would be great if to add a section on the manual about blockit (setup instructions, etc).

Are you using other WebkitWebExtensions?

Thanks for reporting @shamazmazum!

@aadcg aadcg added the 4-series Related to releases whose major version is 4. label Jan 6, 2025
@shamazmazum
Copy link
Contributor Author

@aadcg No, I only use blockit. Will send a PR soon, thanks.

@shamazmazum shamazmazum linked a pull request Jan 11, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4-series Related to releases whose major version is 4. feature Feature requests.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize WebExtension directory. shamazmazum/nyxt
2 participants
@shamazmazum @aadcg