Fix: Extend policy validation to support update and delete actions #522
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouriyabp
requested review from
oboukili,
onematchfox,
blakepettersson,
the-technat and
mkilchhofer
as code owners
… regex Signed-off-by: pouriyabp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix enhances the policy validation function to support the update and delete actions, in addition to the previously supported action keyword.
Per the documentation on Fine-grained Permissions for update/delete actions, the update and delete actions allow users to perform operations on an application and all of its resources. Additionally, these actions can be scoped to specific resources using the
<action>/<group>/<kind>/<ns>/<name>format.To align with this functionality, the regex used in policy validation has been updated to recognize update and delete as valid actions. This ensures that policies leveraging fine-grained permissions for update and delete are now properly validated.
Fixes #524