Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JoinSelection into datafusion-physical-optimizer crate #14073

Open
Tracked by #11502
alamb opened this issue Jan 10, 2025 · 1 comment · May be fixed by #14085
Open
Tracked by #11502

Move JoinSelection into datafusion-physical-optimizer crate #14073

alamb opened this issue Jan 10, 2025 · 1 comment · May be fixed by #14085
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Jan 10, 2025

Is your feature request related to a problem or challenge?

Historically DataFusion was one (very) large crate datafusion, and as it grew bigger we extracted various functionality into separate crates. This leads to both faster compile times (as the crates can be compiled in parallel) as well easier to navigate code (as the crates force a cleaner dependency separation)

One project we have not yet completed is to extract the physical optimizer passes out #11502

Describe the solution you'd like

Extract the JoinSelection from the datafusion core crate to the datafusion-physical-optimizer crate

Describe alternatives you've considered

Move https://github.com/apache/datafusion/blob/main/datafusion/core/src/physical_optimizer/join_selection.rs to
https://github.com/apache/datafusion/tree/main/datafusion/physical-optimizer/src/

Additional context

Here is an example PR:

I think this is a good first issue as it is mostly mechanical and does not require deep internals knowledge

@alamb alamb added the enhancement New feature or request label Jan 10, 2025
@alamb alamb added the good first issue Good for newcomers label Jan 10, 2025
@cj-zhukov
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants