Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility warning when upgrading to React 18 #19

Open
ududsha opened this issue Apr 8, 2022 · 3 comments
Open

Incompatibility warning when upgrading to React 18 #19

ududsha opened this issue Apr 8, 2022 · 3 comments

Comments

@ududsha
Copy link

ududsha commented Apr 8, 2022

I have upgraded our app with React 18 and got the below warning since I am using react-webcomponentify.

image

Since React 18 is not supporting ReactDOM.render, we are getting this. Instead of that we should use createRoot API and its mentioned in their upgrade guide.
I suggest to upgrade the library to support React 18 with proper backward compatibility with older versions.

I would love to contribute on that.
Let me know if you have any nicer suggestion or any plans already in mind @kopach @a7ul .

@a7ul
Copy link
Owner

a7ul commented Apr 8, 2022

Awesome @ududsha can you maybe raise a pr for this?

@ududsha
Copy link
Author

ududsha commented Apr 8, 2022

Sure Let me work on it! Thanks @a7ul

@ududsha
Copy link
Author

ududsha commented Apr 22, 2022

Hi @a7ul, I have upgraded the library with React18, but it seems still have issues when we are going to use in another project. Really appreciate if someone can help checking this => https://github.com/ududsha/react-webcomponentify/commits/feature/upgrade-to-react18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants