Show bundle components on the cart page #3478
Conversation
|
It seems like bundle components are still not shown on the cart page. Why has this not made it into Dawn yet? |
sections/main-cart-items.liquid
Outdated
| <sub> | ||
| {{ component.title }} | ||
| {%- if component.quantity > 1 -%} | ||
| <span> × {{ component.quantity }}</span> | ||
| {%- endif -%} | ||
| </sub> |
There was a problem hiding this comment.
I wonder if this is the right element for the job. Id go with an unordered list instead maybe.
When i look at the sub element in docs, MDN for example, it does mention using them in specific scenarios:
should be displayed as subscript for solely typographical reasons
There was a problem hiding this comment.
I notice others have conditionals for default variants, size, and selling plans, but there's no explicit check for whether the item is a bundle. Did we intend to add a condition for that, or is it not necessary in this particular context?
There was a problem hiding this comment.
Also if added to cart isn't this needed on orders page as well?!
There was a problem hiding this comment.
@ludoboludo I've switched it to an unordered list — does it look better now?
It might need a bit of CSS tweaking, especially for the left margin.
PR Summary:
Show bundle components on the cart page
Why are these changes introduced?
Fixes #3477
What approach did you take?
Render
item.item_componentsif they are present.Other considerations
n/a
Decision log
n/a
Visual impact on existing themes
Enhance user experience for bundles.
Testing steps/scenarios
Demo links
Chromium.mp4
Checklist