All committers have signed the CLA.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

LocatorType = Union[Tuple[ByType, str], Tuple[RelativeBy, None]]

PR Code Suggestions ✨

Explore these optional code suggestions:

 def find_element(self, by: Union[ByType, RelativeBy] = By.ID,
                  value: Optional[str] = None) -> WebElement:
+    if isinstance(by, RelativeBy):
+        elements = by.find_elements(self)
+        if not elements:
+            raise NoSuchElementException(f"Cannot locate relative element with: {by.root}")
+        return elements[0]
+
     if by == By.CLASS_NAME:
         by = By.CSS_SELECTOR
         value = f".{value}"
     elif by == By.NAME:
         by = By.CSS_SELECTOR
         value = f'[name="{value}"]'
 
     return self._execute(Command.FIND_ELEMENT_FROM_SHADOW_ROOT, {"using": by, "value": value})["value"]

-LocatorType = Union[Tuple[ByType, str], Tuple[RelativeBy, None]]
+LocatorType = Union[Tuple[ByType, str], Tuple[RelativeBy, Optional[str]]]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.86%. Comparing base (57f8398) to head (28d4f96).
Report is 1141 commits behind head on trunk.

@@            Coverage Diff             @@
##            trunk   #15050      +/-   ##
==========================================
+ Coverage   58.48%   58.86%   +0.38%     
==========================================
  Files          86       94       +8     
  Lines        5270     6012     +742     
  Branches      220      259      +39     
==========================================
+ Hits         3082     3539     +457     
- Misses       1968     2214     +246     
- Partials      220      259      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gryznar Thanks for the PR!

Please run scripts/format.sh to pass the formatting tests

Sure. I was not aware of this script and therefore I've formatted manually

Sure. I was not aware of this script and therefore I've formatted manually

No worries, I didn't know about it either until someone directed me to it

Please run scripts/format.sh to pass the formatting tests

@shbenzer Done

I've also reverted changes in shadowroot.py, because they were causing circular imports