init_params! inconsistent call signature cause trouble

[korsbo]

In some places init_params! is defined with rng as a kwarg and in some places it's an arg.

[korsbo]

SimpleChains.jl/src/simple_chain.jl

Lines 390 to 399 in 6fbf2b0

	function init_params!(
	chn::SimpleChain, x::AbstractVector, id = nothing; rng::AbstractRNG
	)
	GC.@preserve x init_params!(chn.layers, pointer(x), chain_input_dims(chn, id), rng)
	return x
	end
	function init_params!(layers::Tuple, p::Ptr, id, rng::AbstractRNG)
	p, od = init_params!(first(layers), p, id, rng)
	init_params!(Base.tail(layers), p, od, rng)
	end

[korsbo]

I'm not even sure that this was my original problem. I was hitting the error that rng was an undefined kwarg. Maybe just add a default to that kw?

[chriselrod]

Do you want me to rename those methods _init_params instead? Users should be calling the ::Tuple methods.
The ::Tuple methods have an rng as a positional argument, and the API ones that take an AbstractChain have it as a kwarg.

Any exceptions to that are a bug.