https://….git#hash links should be recognized correctly

[Profpatsch]

A lockfile entry like

"dfinity-tx@git+https://github.com/dfinity/js-dfinity-tx.git":
  version "0.0.1"
  resolved "git+https://github.com/dfinity/js-dfinity-tx.git#32240a29f03e1e5062dcd8f8e4ff50eb69bb91a0"
  dependencies:
    assert "^1.4.1"
    borc "git+https://github.com/dignifiedquire/borc.git#fix/nested-array"
    events "^2.0.0"
    safe-buffer "^5.1.1"
    secp256k1 "^3.3.1"

"dfinity-tx@https://github.com/dfinity/js-dfinity-tx.git":
  version "0.0.1"
  resolved "https://github.com/dfinity/js-dfinity-tx.git#8657759ce78bde01c16858a9543c1d069a77333f"
  dependencies:
    assert "^1.4.1"
    borc "^2.0.3"
    events "^2.0.0"
    safe-buffer "^5.1.1"
    secp256k1 "^3.3.1"

Generates this nix expression:

        "[email protected]" = f "dfinity-tx" "0.0.1" (ir "https://github.com/dfinity/js-dfinity-tx.git") "8657759ce78bde01c16858a9543c1d069a77333f" [
          (s."assert@^1.4.1")
          (s."borc@^2.0.3")
          (s."events@^2.0.0")
          (s."safe-buffer@^5.1.1")
          (s."secp256k1@^3.3.1")
        ];
        "dfinity-tx@git+https://github.com/dfinity/js-dfinity-tx.git" = s."[email protected]";
        "dfinity-tx@https://github.com/dfinity/js-dfinity-tx.git" = s."[email protected]";

f and ir resolve to fetchurl, so that is clearly wrong.

The second entry’s link has the form:

https://github.com/dfinity/js-dfinity-tx.git#8657759ce78bde01c16858a9543c1d069a77333f

So we should probably parse everything that ends in .git and contains a hash as a GitRemote.

Note that the bug happens because the yarn.lock file format is very ill structured and provides no easy way to distinguish different kinds of remotes from each other. Thus, the logic in https://github.com/Profpatsch/yarn-lock/blob/master/src/Yarn/Lock/File.hs#L114-L160 is one of the most brittle path of yarn2nix (while the other brittle part is the rest of the parser). This is also where these changes need to be implemented.

The corresponding tests in https://github.com/Profpatsch/yarn-lock/blob/master/tests/TestFile.hs#L30-L47 need to be amended as well.

Thanks to @jwiegley for the bug report!