Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't quite understand the method 'WithScenarioCompletionTimeout' #745

Open
Libra321 opened this issue Sep 26, 2024 · 6 comments
Open
Labels
5.10 question Further information is requested

Comments

@Libra321
Copy link

My NBOMBER version is V5.7.0,Refer to your timeout demo,I have changed the timeout to 10, 4, and 3 respectively,Unable to understand the results
image
image
image

@AntyaDev
Copy link
Contributor

AntyaDev commented Sep 27, 2024

Hi @Libra321

After the Scenario duration (1 sec in your case), NBomber does some preparation and calculation, which takes some time.
After this, it will run internal function waitOnWorkingActors() and wait on completion of all scheduled Scenarios (ScenarioCompleationTimeout).

So basically you have: Scenario duration (1 sec) + NBomber finalization + 3 sec (ScenarioCompleationTimeout)

@AntyaDev
Copy link
Contributor

@Libra321
Do I understand that you want NBomber to stop measuring requests at the exact end time of the scenario?

@AntyaDev AntyaDev added question Further information is requested 5.8 labels Oct 4, 2024
@Libra321
Copy link
Author

Libra321 commented Oct 8, 2024

@AntyaDev
Yes, otherwise the test results would be unbelievable

@AntyaDev
Copy link
Contributor

AntyaDev commented Oct 8, 2024

Got you. One more question: what are your thoughts about the following use case:

  • You defined a Scenario with a duration of 30 sec.
  • Let's imagine that handling one request takes 1 second.
    What should happen with a request that started at 29.5 seconds? This request will be finished in 30.5 seconds. Do you want to see it in the NBomber stats report, or should it be ignored?

@Libra321
Copy link
Author

Libra321 commented Oct 9, 2024

@AntyaDev Normally, if the task is not completed within 30 seconds, it should be ignored. However, if the "WithScenarioCompletionTimeout" time is set, it should be effective

@AntyaDev
Copy link
Contributor

Ok, let me think what we can do about it. I will ping you a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.10 question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants