Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing mdcheck script #332096

Open
lierdakil opened this issue Aug 3, 2024 · 3 comments · May be fixed by #373222
Open

Missing mdcheck script #332096

lierdakil opened this issue Aug 3, 2024 · 3 comments · May be fixed by #373222
Labels
0.kind: bug Something is broken

Comments

@lierdakil
Copy link
Contributor

lierdakil commented Aug 3, 2024 •
edited
Loading

Describe the bug

When swraid is enabled, also systemd timer units mdcheck_start etc are installed. mdcheck_start.service and mdcheck_continue.service include references to /usr/share/mdadm/mdcheck script. But the script is missing in that location. In fact, it's missing from the mdadm closure entirely.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Enable swraid
  2. systemctl cat mdcheck_start, note ExecStart referencing /usr/share/mdadm/mdcheck
  3. Observe that /usr/share/mdadm/mdcheck does not, in fact, exist

Expected behavior

The ExecStart path to point to an existing file.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Nixpkgs 7bba2df

Notify maintainers

I guess @Ekleog?

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.41, NixOS, 24.05 (Uakari), 24.05.20240728.7bba2df`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/vmpqgycgppcl0limg2xsl1sbr6d716jx-source`

Add a 👍 reaction to issues you find important.
@lierdakil lierdakil added the 0.kind: bug Something is broken label Aug 3, 2024
@lierdakil lierdakil mentioned this issue Aug 4, 2024
Closed
13 tasks
@eclairevoyant
Copy link
Contributor

We're not gonna put stuff in /usr, if anything it should be built with a flag or patched to the correct prefix

@lierdakil
Copy link
Contributor Author

lierdakil commented Aug 4, 2024 •
edited
Loading

The point is, currently, broken systemd units are installed. Also, their presence creates a false impression that periodic scrubbing happens on NixOS, which it absolutely does not because the script that does the actual work is nowhere to be found. How exactly that is fixed is secondary, but it needs to be fixed.

@eclairevoyant
Copy link
Contributor

Sure systemd services shouldn't point to nonexistent paths, but this is a github issue tracker, of course we will discuss how things should be fixed.

@ElvishJerricco ElvishJerricco mentioned this issue Oct 15, 2024
Closed
9 tasks
@sbruder sbruder linked a pull request Jan 12, 2025 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nixos/mdcheck: init module sbruder/nixpkgs
2 participants
@eclairevoyant @lierdakil