cryfs: 0.11.4 -> 1.0.1 #372862
Open
cryfs: 0.11.4 -> 1.0.1 #372862
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natsukium
reviewed
Jan 12, 2025
| @@ -64,13 +63,11 @@ stdenv.mkDerivation rec { | |||
| spdlog | |||
| ] ++ lib.optional stdenv.cc.isClang llvmPackages.openmp; | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| buildInputs = [ gtest ]; |
Did you manage to build this on Linux? CMake errors out with a missing gtest error.
Comment on lines
67
to
+70
| "-DDEPENDENCY_CONFIG='../cmake-utils/DependenciesFromLocalSystem.cmake'" | ||
| "-DCRYFS_UPDATE_CHECKS:BOOL=FALSE" | ||
| "-DBoost_USE_STATIC_LIBS:BOOL=FALSE" # this option is case sensitive | ||
| "-DBUILD_TESTING:BOOL=${if doCheck then "TRUE" else "FALSE"}" | ||
| "-DBUILD_TESTING:BOOL=${if finalAttrs.doCheck then "TRUE" else "FALSE"}" |
There was a problem hiding this comment.
I think this can be written a lot more cleanly with the lib.cmake* function family.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372761
Changelog: https://github.com/cryfs/cryfs/releases/tag/1.0.1
Diff: cryfs/cryfs@0.11.4...1.0.1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.