-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 downloads are not interruptable #11678
Comments
@edolstra ill work on this issue if you can assign me this |
As a first-time contributor, I'd like some help. Where should I implement the new nix/src/libstore/s3-binary-cache-store.cc Line 92 in dbcd4cd
|
I'm somewhat confused by the current implementation. Why does S3 fetching live inside |
Also S3 fetching is already problematic and it's not clear how it handles compressed streams? Does the AWS SDK handle the decompression (can it even do that?) or should it be handled the same way that it's done for regular HTTP with libarchive and It would be very helpful to define interface boundaries so that there are clear and defined requirements and api for file transfers/stream decompression/progress tracking. This would be better in the long run than piling amazingly complex logic into a single class. |
I've made an attempt in #12227, it's a little delayed at closing out but it does seem to improve the problem. |
Describe the bug
For instance, hitting Ctrl-C during
does nothing.
Steps To Reproduce
Expected behavior
Nix should exit with
error: interrupted by the user
quickly.Probably the easiest way to do this is to have
S3Helper::getObject()
use anstd::stringstream
wrapper that callscheckInterrupt()
.nix-env --version
outputAdditional context
Add any other context about the problem here.
Priorities
Add 👍 to issues you find important.
The text was updated successfully, but these errors were encountered: