Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: distinguish by the need of network connection #22

Open
nico202 opened this issue Feb 15, 2020 · 3 comments
Open

Tests: distinguish by the need of network connection #22

nico202 opened this issue Feb 15, 2020 · 3 comments

Comments

@nico202
Copy link

nico202 commented Feb 15, 2020

Hi, I'm building this library on guix. The build environment does not have network connection. I'd still like to run as many tests as possible, so it would be useful to have a flag that distinguish between those that depends on a working network connection and those that can be run locally.

Thanks!

@nico202
Copy link
Author

nico202 commented Feb 15, 2020

Those are failing for me

  • BasicConnectivity :: freeze
  • ClientAPI :: freeze
  • MediaAPI :: media_api.cpp:49: err: actual true, expected false
  • Encryption :: freeze

@deepbluev7
Copy link
Member

Yes, this is also a big issue for me, since I don't have docker on my laptop, so I can't run the network tests there. We should definitely do that!

@deepbluev7 deepbluev7 self-assigned this Mar 4, 2020
@deepbluev7 deepbluev7 removed their assignment Oct 1, 2020
@deepbluev7
Copy link
Member

deepbluev7 commented Oct 7, 2021

If you use meson to build mtxclient, there are now 2 suites. nonetwork should be able to run without network. There might be some tests that are excluded, that could be run without network, but are not in that suite and we don't test it without network that often though, but it should be a first step. (Nheko also can't be built against he meson version yet)

https://github.com/Nheko-Reborn/mtxclient/blob/master/tests/meson.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants