[Bug]: Gas - TypeError: Cannot set properties of undefined (setting 'gasFeeEstimates')
#27241
Assignees
Labels
regression-RC-12.3.0
Regression bug that was found in release candidate (RC) for release 12.3.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-confirmations
Push issues to confirmations team
type-bug
Comments
metamaskbot
added
the
regression-RC-12.3.0
gauthierpetetin
added
team-confirmations
|
@seaona if you cannot reproduce should we close it? |
|
I've just encountered it again in 12.3.0 and I've seen that there are more than 90k entries for this error in Sentry. So I think that investigating repro steps and trying to address it would definitely help reducing Sentry errors.
We could open the Sentry issue too if that's more helpful to link data, and get more debugging info. What do you think?
|
|
Found some repro steps cc @cryptotavares : Repro:
gasEstimates-undefined.mp4 |
7 tasks
|
The issue will be fixed by PR. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 20, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR fixes an issue created by Sentry where the property `gasFeeEstimates` is `undefined`. Added an early return when the property is `undefined` and covered the scenario with unit tests. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/29312?quickstart=1) ## **Related issues** Fixes: #27501 #27241 ## **Manual testing steps** 1. Go to this test dapp 2. Block requests against gas-api 3. Start a send or contract interaction 4. Verify the console ## **Screenshots/Recordings** [block-gas-api.webm](https://github.com/user-attachments/assets/1c3cf638-905e-4df9-b875-84f0056979b1) <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/29312?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Background error
TypeError: Cannot set properties of undefined (setting 'gasFeeEstimates'). I haven't seen any UI impact, but cannot reproduce again, to be able to add more detailsExpected behavior
No response
Screenshots/Recordings
Steps to reproduce
To determine.
I was using 2 networks for 2 different dapps (Sepolia and Linea Sepolia) and switching back and forth triggering txs.
Error messages or log output
No response
Detection stage
During release testing
Version
12.3.0
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: