Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only those in LAN may access Web UI ipv6 support #1775

Open
3 tasks done
axet opened this issue Oct 23, 2023 · 5 comments
Open
3 tasks done

Only those in LAN may access Web UI ipv6 support #1775

axet opened this issue Oct 23, 2023 · 5 comments
Assignees
Labels
network Network issue

Comments

@axet
Copy link

axet commented Oct 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your issue described in the documentation?

  • I have read the documentation

Is your issue present in the nightly release?

  • This issue is present in the nightly release

Describe the Bug

Config option "Only those in LAN may access Web UI" working incorrectly. Current implementation only only check IPv4 for unroutable address. But here is also IPv6 with unrotable (local link) addresses. You can see all unroutable addresses in wikipeida:

Expected Behavior

No response

Additional Context

No response

Host Operating System

Linux

Operating System Version

bookworm

Architecture

64 bit

Sunshine commit or version

0.21.0

Package

Linux - flatpak

GPU Type

AMD

GPU Model

rx 6600

GPU Driver/Mesa Version

0000

Capture Method (Linux Only)

No response

Config

000

Apps

No response

Relevant log output

000
@ReenigneArcher ReenigneArcher added the network Network issue label Oct 23, 2023
@cgutman
Copy link
Collaborator

cgutman commented Oct 28, 2023

Yes, this is a known limitation of our IPv6 support. We do not currently have any method of enumerating interfaces and addresses in our platform-specific backends, so we can't tell if a given address is on-link or not.

@axet
Copy link
Author

axet commented Oct 28, 2023

No need for that. Listening 0.0.0.0 - makes you ipv4 only. Listening :: makes you ipv4/ipv6. You have peer address which can be validated for local node connection / remote connection.

@cgutman
Copy link
Collaborator

cgutman commented Oct 30, 2023

I don't understand what you're suggesting. Yes, we can listen on 0.0.0.0 or :: and that's exactly what we already do depending on whether you selected IPv4-only or IPv6+IPv4 in Sunshine's configuration.

As I mentioned, we need to know whether the peer address is on-link or not. Unlike IPv4, you can't easily know that based on the address alone. You need to enumerate the assigned addresses and subnet masks on local interfaces to determine on-link destinations, and that isn't implemented yet.

@axet
Copy link
Author

axet commented Oct 30, 2023

Not true. Unless you also want to add routable local IPv6 addresses, which BTW I do not recommend. IPv6 not a bit different from IPv4.

Check unroutable addesses (local link)

@LizardByte-bot
Copy link
Member

It seems this issue hasn't had any activity in the past 90 days. If it's still something you'd like addressed, please let us know by leaving a comment. Otherwise, to help keep our backlog tidy, we'll be closing this issue in 10 days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Network issue
Projects
None yet
Development

No branches or pull requests

4 participants