Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JuliaControl Bot #353

Open
1 of 2 tasks
mfalt opened this issue Oct 9, 2020 · 1 comment
Open
1 of 2 tasks

JuliaControl Bot #353

mfalt opened this issue Oct 9, 2020 · 1 comment

Comments

@mfalt
Copy link
Member

mfalt commented Oct 9, 2020

I thought we should have an issue discussing how we want the @JuliaControlBot to work.
Currently

Should we reduce the number of posts the bot makes in some way?
Should it delete old posts?
Should it refuse to run on PRs that are not up to date with master? Otherwise the bot might report false changes.
Should we automatically pull branches into ControlExamplePlots when a PR is pulled into master? Or maybe automatically run an update ControlExamplePlots whenever master changes?

Proposed changes:

  • Bugfix: It seems like the bot recognizes some types of comments as changes and runs a new check and post
  • Add link to the new branch on ControlExamplePlots in the PR reply (Fixed in JuliaControl/ControlExamplePlots.jl@d851414)
@baggepinnen
Copy link
Member

Should we reduce the number of posts the bot makes in some way?

I don't think the current number of posts is disturbing

Should it delete old posts?

Might be confusing to read follow-up posts if the post they are following up on are gone

Should it refuse to run on PRs that are not up to date with master? Otherwise the bot might report false changes.

Sounds like a good idea

Should we automatically pull branches into ControlExamplePlots when a PR is pulled into master? Or maybe automatically run an update ControlExamplePlots whenever master changes?

Some form of automatic handling would be nice, because we (at least I) will probably forget otherwise. I can't judge between your two suggested strategies so feel free to choose :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants