Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we are always re-using boto3 clients #1526

Open
terrazoon opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1528
Open

Make sure we are always re-using boto3 clients #1526

terrazoon opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1528
Assignees
@terrazoon

Comments

@terrazoon
Copy link
Contributor

terrazoon commented Jan 8, 2025 •
edited
Loading

Boto3 clients are thread safe and have built in connection pooling so we should be creating one instance of each flavor (logs, s3, etc.) at the app level and reusing them.
@terrazoon terrazoon converted this from a draft issue Jan 8, 2025
@terrazoon terrazoon self-assigned this Jan 8, 2025
@terrazoon terrazoon moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Jan 8, 2025
@terrazoon terrazoon moved this from 🏗 In progress (WIP: ≤ 3 per person) to 👀 In review in Notify.gov product board Jan 9, 2025
@terrazoon terrazoon linked a pull request Jan 9, 2025 that will close this issue
make sure we reuse boto3 clients and resources #1528
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrazoon terrazoon

Labels
None yet
Projects
Notify.gov product board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure we reuse boto3 clients and resources GSA/notifications-api
1 participant
@terrazoon