Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dialog component #3266

Closed
mnigh opened this issue Jul 5, 2022 · 2 comments
Closed

Refactor Dialog component #3266

mnigh opened this issue Jul 5, 2022 · 2 comments
Labels
debt Refactor or improve existing code.

Comments

@mnigh
Copy link
Contributor

mnigh commented Jul 5, 2022

Notes

  • use low level components (DialogOverlay, DialogContent) instead of creating our own nested components (Overlay, Content)
  • remove footer prop
  • add individual props for actions (firstAction?, secondAction?)
  • add required dismissible close button that is first focused element in top right-hand corner
@tristan-orourke
Copy link
Member

We should account for three actions (roughly cancel, proceed and decline).
But we need to account for edge cases (eg forms).
Maybe makes sense to have our own footer component which accepts the three buttons but can be wrapped in other contexts if necessary.

@tristan-orourke tristan-orourke added the debt Refactor or improve existing code. label Jul 7, 2022
@esizer esizer self-assigned this Jul 19, 2022
@esizer esizer removed their assignment Jul 19, 2022
@esizer
Copy link
Member

esizer commented Nov 10, 2022

Closed by #4136

@mnigh mnigh closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Refactor or improve existing code.
Projects
None yet
Development

No branches or pull requests

3 participants