Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help update @reach/dialog to be compatible with React 18, or migrate to another compatible backing component #679

Closed
frankieyan opened this issue Aug 9, 2022 · 0 comments · Fixed by #686
Assignees

Comments

@frankieyan
Copy link
Member

frankieyan commented Aug 9, 2022

We rely on Reach-UI's Dialog component to power our Modal.

In Todoist, there are 11 modals built using the Reactist Modal, and 27 in Twist. Todoist also pulls in @reach/dialog directly and uses it to implement another 27 modals, bringing the total to 38.

There is an opportunity to contribute back to Reach-UI - its author is looking for help in making the component suite React 18 compatible (ref).

An alternative we can consider is to use Ariakit's Dialog. It works with React 18 and we already have it as a dependency after migrating other Reakit-backed components over. Ideally, we pick one backing library to power Reactist as there are shared dependencies and lower-level components each of these components use.

Twist discussion: https://twist.com/a/1585/ch/190200/t/3686215/

@frankieyan frankieyan changed the title Replace @reach/dialog with a React 18 compatible backing component Help update @reach/dialog to be compatible with React 18, or migrate to another React 18 compatible backing component Aug 9, 2022
@frankieyan frankieyan changed the title Help update @reach/dialog to be compatible with React 18, or migrate to another React 18 compatible backing component Help update @reach/dialog to be compatible with React 18, or migrate to another compatible backing component Aug 9, 2022
@frankieyan frankieyan self-assigned this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant