Fix in-page link without target #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… roles from links to list items
|
I think if they're supposed to be buttons, |
|
Good point. Was referencing the W3C WAI-ARIA menubar example: While both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #79
For
twitterConnectBtnandfbConnectBtnare not for page navigation( there are event listeners are bound to them instead), removeatags and movemenuitemrole item to list items insteadNote. this UI is actually not in accessibility tree for its grandparent has
display: nonestyle. We can see if we want to review whether to include these types of issues in the board