Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Issue 21: In-page link without target (Closed Page) #79

Open
NewJerseyStyle opened this issue Oct 31, 2024 · 3 comments · May be fixed by #112
Open

[a11y] Issue 21: In-page link without target (Closed Page) #79

NewJerseyStyle opened this issue Oct 31, 2024 · 3 comments · May be fixed by #112
Assignees

Comments

@NewJerseyStyle
Copy link
Member

Description:

An in-page link on the closed page has an href attribute starting with #, but the corresponding target element (identified by id or name attribute) is missing.

Steps to Reproduce:

  1. Navigate to the closed page.
  2. Inspect the problematic link using developer tools.

Expected Behavior:

The link should have a corresponding target element within the page or the link should be removed.

Actual Behavior:

In-page link without a matching target.

Component/Area: Closed Page

Source: Auto evaluation

Affected Elements: An in-page link has an href attribute (starting with a #), but does not match either the id value of another element or the name attribute value of an anchor element within the page.

@YumiChen
Copy link
Member

YumiChen commented Jan 17, 2025

I'd like to work on this issue. Could I double check which page is Closed Page referring to?

I think I found the page ( closed conversation) No worries

@NewJerseyStyle
Copy link
Member Author

Which is the state of participation page, when the conversation is set to closed, the participation page become Closed Page

Image
The state is changed through admin panel of the conversation by checking and unchecking Conversation is open. Unchecking disables both voting and commenting.

@YumiChen
Copy link
Member

Thanks for the clarification @NewJerseyStyle!

@YumiChen YumiChen linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants