Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Rename Auth0 roles: "Trainee" to "Call Trainee" and "VIAL data corrections" to "VIAL WB full access" #611

Closed
simonw opened this issue May 27, 2021 · 5 comments
Assignees
Labels
authentication Auth0 and API tokens security Security-focused change wontfix This will not be worked on

Comments

@simonw
Copy link
Collaborator

simonw commented May 27, 2021

while you're at it -- if we can coordinate changing the names of two existing auth0 roles, that would be nice:

  • "Trainee" to "Call Trainee" (affects the logic autoflagging these reports for various things)
  • "VIAL data corrections" role to "VIAL WB full access" (affects the logic syncing the auth0 role to the VIAL group)

Originally posted by @rhkeeler in #609 (comment)

@simonw simonw added authentication Auth0 and API tokens security Security-focused change labels May 27, 2021
@simonw
Copy link
Collaborator Author

simonw commented May 27, 2021

Renaming roles in Auth0 breaks their connection to VIAL, so we need to co-ordinate this change carefully:

  1. Add code to VIAL such that Auth0 users with EITHER of the names for the roles are mapped to a VIAL group of the new name
  2. Deploy a database migration that renames the existing VIAL role (since we want to keep the permissions that have been assigned to it within VIAL)
  3. Edit the name in the Auth0 interface
  4. Once we're confident everything is working, we can change the code in VIAL to get clean up by getting rid of the backwards-compatibility code

@ugotsoul ugotsoul self-assigned this Jun 3, 2021
@lisabettefay
Copy link

I think we are still having an issue with the WB Trainee role not flagging 100% of web banked reports. I have assigned these people Trainee as a workaround.

@rhkeeler rhkeeler added the wontfix This will not be worked on label Jun 15, 2021
@rhkeeler
Copy link

@lisabettefay yeah Ugaso's working on that in #633

@ugotsoul
Copy link
Contributor

WB Trainee roles should work as expected after the user logs back in and out now.

@ugotsoul
Copy link
Contributor

oh and just to clarify: #633 is to address the issue of roles not updating when the user is still logged in (nice to have!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Auth0 and API tokens security Security-focused change wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants